[PATCH] D96117: [AMDGPU][MC] Corrected error position for invalid dim modifiers

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 09:28:34 PST 2021

Previous message: [PATCH] D96117: [AMDGPU][MC] Corrected error position for invalid dim modifiers
Next message: [PATCH] D96117: [AMDGPU][MC] Corrected error position for invalid dim modifiers
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

Looks good, thanks! Aa an alternative, parseDimId could return Optional<unsigned>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96117/new/

https://reviews.llvm.org/D96117

Previous message: [PATCH] D96117: [AMDGPU][MC] Corrected error position for invalid dim modifiers
Next message: [PATCH] D96117: [AMDGPU][MC] Corrected error position for invalid dim modifiers
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list