[PATCH] D96104: [test-suite] SPEC2017 CPU Fotonik3d floating point tests.

Fri Feb 5 08:50:14 PST 2021

Meinersbur added inline comments.

================
Comment at: External/SPEC/CFP2017rate/549.fotonik3d_r/CMakeLists.txt:11-13
+speccpu2017_run_test(
+  RUN_TYPE test
+)
----------------
What does this do without a command to run?

================
Comment at: External/SPEC/CFP2017rate/549.fotonik3d_r/CMakeLists.txt:30-31
+# fotonik3d has both relative and absolute tolerances
+speccpu2017_verify_output(RELATIVE_TOLERANCE 1.0e-10)
+speccpu2017_verify_output(ABSOLUTE_TOLERANCE 1.0e-27)
+
----------------
Does fpcmd work with both tolerances in one invocation?

================
Comment at: External/SPEC/CFP2017rate/549.fotonik3d_r/CMakeLists.txt:63
+            "${TEST_SUITE_SPEC2017_ROOT}/bin/specxz"
+    COMMAND "${TEST_SUITE_SPEC2017_ROOT}/bin/specxz"
+            -dc "${INPUT_${_run_type}_DIR}/OBJ.dat.xz"
----------------
Files in this dir requires to run the install script, where I up to now just extracted the archive. (`specxz` is in `\tools\bin\$platform`). In addition, the platform on which cmake runs, llvm-lit is invoked, and the tests executables are running (`TEST_SUITE_REMOTE_HOST`) might not be the same. For which of these architecture is `specxz` supposed to be?

Is there any possibility to not require installation?

================
Comment at: External/SPEC/CFP2017rate/CMakeLists.txt:14
 add_subdirectory(544.nab_r)        # C
-#add_subdirectory(549.fotonik3d_r) # Fortran
+add_subdirectory(549.fotonik3d_r)  # Fortran
 #add_subdirectory(554.roms_r)      # Fortran
----------------

================
Comment at: External/SPEC/CFP2017speed/CMakeLists.txt:11
 add_subdirectory(644.nab_s)        # C
-#add_subdirectory(649.fotonik3d_s) # Fortran
+add_subdirectory(649.fotonik3d_s) # Fortran
 #add_subdirectory(654.roms_s)      # Fortran
----------------

Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96104/new/

https://reviews.llvm.org/D96104