[PATCH] D95806: [LoopUnrollAndJam] Do not allows loops which have no exit(ing) blocks or multiple exit(ing) blocks

[Sidharth Baveja via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG22ebbc476557: LoopUnrollAndJam] Only allow loops with single exit(ing) blocks (authored by sidbav).

Changed prior to commit:
  https://reviews.llvm.org/D95806?vs=321148&id=321765#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95806/new/

https://reviews.llvm.org/D95806

Files:
  llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
  llvm/test/Transforms/LoopUnrollAndJam/multiple_exit_blocks.ll


Index: llvm/test/Transforms/LoopUnrollAndJam/multiple_exit_blocks.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/LoopUnrollAndJam/multiple_exit_blocks.ll
@@ -0,0 +1,49 @@
+; REQUIRES: asserts
+; RUN: opt -debug-only=loop-unroll-and-jam -passes="loop-unroll-and-jam" -enable-unroll-and-jam -allow-unroll-and-jam -unroll-and-jam-count=8 -disable-output %s 2>&1 | FileCheck %s
+
+; CHECK: Loop Unroll and Jam: F[h] Loop %bb8
+; CHECK: Won't unroll-and-jam; only loops with single exit blocks can be unrolled and jammed
+
+ at a = external global i16, align 2
+ at e = external global i32, align 4
+ at f = external global i16, align 2
+ at b = external global i16, align 2
+ at c = external global i64, align 8
+
+define void @h() {
+bb:
+  store i32 4, i32* @e, align 4
+  %i15 = load i16, i16* @b, align 2
+  %i17 = icmp slt i16 %i15, 1
+  br label %bb8
+
+bb8:                                              ; preds = %bb, %bb47
+  %storemerge15 = phi i32 [ 4, %bb ], [ %i49, %bb47 ]
+  br label %bb24
+
+bb24:                                             ; preds = %bb43, %bb8
+  %storemerge312 = phi i16 [ 0, %bb8 ], [ %i45, %bb43 ]
+  br i1 %i17, label %bb46.preheader, label %bb43
+
+bb46.preheader:                                   ; preds = %bb24
+  store i16 %storemerge312, i16* @f, align 2
+  br label %bb46
+
+bb43:                                             ; preds = %bb24
+  %i45 = add nuw nsw i16 %storemerge312, 1
+  %i13 = icmp ult i16 %storemerge312, 7
+  br i1 %i13, label %bb24, label %bb47
+
+bb46:                                             ; preds = %bb46.preheader, %bb46
+  br label %bb46
+
+bb47:                                             ; preds = %bb43
+  %i49 = add nsw i32 %storemerge15, -1
+  store i32 %i49, i32* @e, align 4
+  %i7.not = icmp eq i32 %i49, 0
+  br i1 %i7.not, label %bb50, label %bb8
+
+bb50:                                             ; preds = %bb47
+  store i16 %i45, i16* @f, align 2
+  ret void
+}
Index: llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
===================================================================
--- llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
+++ llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
@@ -831,6 +831,23 @@
     if (SubLoopsSize != 1)
       return false;
 
+    // Only loops with a single exit block can be unrolled and jammed.
+    // The function getExitBlock() is used for this check, rather than
+    // getUniqueExitBlock() to ensure loops with mulitple exit edges are
+    // disallowed.
+    if (!L->getExitBlock()) {
+      LLVM_DEBUG(dbgs() << "Won't unroll-and-jam; only loops with single exit "
+                           "blocks can be unrolled and jammed.\n");
+      return false;
+    }
+
+    // Only loops with a single exiting block can be unrolled and jammed.
+    if (!L->getExitingBlock()) {
+      LLVM_DEBUG(dbgs() << "Won't unroll-and-jam; only loops with single "
+                           "exiting blocks can be unrolled and jammed.\n");
+      return false;
+    }
+
     L = L->getSubLoops()[0];
   } while (L);
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95806.321765.patch
Type: text/x-patch
Size: 3086 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210205/a6e56323/attachment.bin>