[PATCH] D95966: [AIX][support] Implement getHostCPUName

[David Tenty via Phabricator via llvm-commits]

daltenty added inline comments.


================
Comment at: llvm/lib/Support/Host.cpp:1227-1232
+  case POWER_4:
+    return "pwr4";
+  case POWER_5:
+    return "pwr5";
+  case POWER_6:
+    return "pwr6";
----------------
hubert.reinterpretcast wrote:
> I'm not entirely sure that "something is better than nothing" is necessarily true here for these. All three have variant implementations/modes (e.g., ppc970, pwr5x, pwr6e) that we aren't handling here.
For pwr5x and pwr6e (IIUC don't think we can actually encounter ppc970), looking at the interfaces it seems that AIX won't distinguish the implementation mode, so I'm not sure if we can easily refine this in those case. Presumably this will still be better than returning 'generic' in those cases though though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95966/new/

https://reviews.llvm.org/D95966