[PATCH] D96106: [GVNSink][Fix] Unregister assumptions that are replaced (PR49043)

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D96106#2544339 <https://reviews.llvm.org/D96106#2544339>, @nikic wrote:

> Can you explain why this requires manual handling, and is not handled by the ValueHandle RAUW logic in AC?

Good point. The current value handle RAUW logic is only dealing with affected values, the idea is still valid.
I could replace the

  struct ResultElem {                                                                                                                                                                                                                                        
    WeakTrackingVH Assume;

with a `CallbackVH` to deal with this.

I'll try it out, thought's welcome.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96106/new/

https://reviews.llvm.org/D96106