[PATCH] D94308: [MachineSink] SinkIntoLoop: analyse stores and aliases in between

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer updated this revision to Diff 321736.
SjoerdMeijer added a comment.
Herald added a subscriber: asbirlea.

- This has been tested on the llvm test-suite for correctness and compile times, and both look good.
- This fixes an issue related to loop-invariant checks, the `HasLoopPHIUse` check. It was incorrectly sinking instruction when they were not loop-invariant, i.e. when they had phi uses. This was an existing check, but I missed this when I moved this from MachineLICM to MachineSink. This is now a helper in MachineLoop, and used in both passes.
- I have improved the MIR tests, especially the alias tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94308/new/

https://reviews.llvm.org/D94308

Files:
  llvm/include/llvm/CodeGen/MachineLoopInfo.h
  llvm/lib/CodeGen/MachineLICM.cpp
  llvm/lib/CodeGen/MachineLoopInfo.cpp
  llvm/lib/CodeGen/MachineSink.cpp
  llvm/test/CodeGen/AArch64/loop-sink.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94308.321736.patch
Type: text/x-patch
Size: 65948 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210205/bb2a42cc/attachment-0001.bin>