[PATCH] D96099: [AArch64][GlobalISel] Support the 'returned' parameter attribute.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 06:02:42 PST 2021


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CallLowering.cpp:231
+    MachineIRBuilder &MIRBuilder, SmallVectorImpl<ArgInfo> &Args,
+    ValueHandler &Handler, std::function<bool(EVT)> TypeIsValidForThisReturn,
+    Register ThisReturnReg) const {
----------------
I think it would be better to move this to a proper function in CallLowering, and take a calling convention argument (also not a fan of using EVT, but I guess we're stuck with it for a while)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96099/new/

https://reviews.llvm.org/D96099



More information about the llvm-commits mailing list