[PATCH] D96122: [GlobalISel] Start using vectors in GISelKnownBits

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp:171
+
+      computeKnownBitsImpl(MI.getOperand(i + 1).getReg(), Known2, DemandedElts,
+                           Depth + 1);
----------------
Petar.Avramovic wrote:
> foad wrote:
> > Don't pass in DemandedElts here.
> We don't have such computeKnownBitsImpl in global-isel. Sdag computeKnownBits(SrcOp, Depth + 1) will call computeKnownBits(Op, 'allones', Depth).
OK, well I guess it's harmless, since the operand will never have vector type, so I guess it will be ignored. I just found it a bit confusing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96122/new/

https://reviews.llvm.org/D96122