[PATCH] D95659: [RISCV] Initial support of LoopVectorizer for RISC-V Vector.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 01:52:55 PST 2021


frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4564
+    EVT VT, unsigned AddrSpace, unsigned Align, MachineMemOperand::Flags Flags,
+    bool *Fast) const {
+  if (!VT.isScalableVector())
----------------

```
  /// .... If true, it also returns
  /// whether the unaligned memory access is "fast" in the last argument by
  /// reference.
```

I think this suggests that setting `Fast` is part of the contract. It could theoretically read an uninitialized variable if we don't set it but return true.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95659/new/

https://reviews.llvm.org/D95659



More information about the llvm-commits mailing list