[PATCH] D96010: [llvm-readobj] Print empty line between note sections in GNU mode
Alexander Richardson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 5 01:48:14 PST 2021
arichardson added a comment.
In D96010#2544304 <https://reviews.llvm.org/D96010#2544304>, @jhenderson wrote:
> Does GNU readelf print an empty line after the last entry too? If so, LGTM.
Apparently GNU readelf doesn't print a newline after the last notes section, whereas we do here. I'm not sure whether it's important to avoid since we would need to track whether we are dumping the last section and that adds quite a bit of complexity to avoid a trailing newline.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96010/new/
https://reviews.llvm.org/D96010
More information about the llvm-commits
mailing list