[PATCH] D74367: [llvm-readelf] Print raw ELF note contents if we can't parse it

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 01:32:56 PST 2021


arichardson marked 5 inline comments as done.
arichardson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/note-generic.s:4
 
-// RUN: llvm-readobj --notes %t.o | FileCheck %s --check-prefix=LLVM
-// RUN: llvm-readelf --notes %t.o | FileCheck %s --check-prefix=GNU
+// RUN: x86_64-elf-readelf --notes %t.o
+// RUN: llvm-readelf --notes %t.o
----------------
jhenderson wrote:
> This looks wrong?
> 
> Also, I'm not sure why this test is changing as part of this change?
Yes, sorry about that - it's a debugging leftover to compare against GNU readelf and the changes should be part of D96010. Will fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74367/new/

https://reviews.llvm.org/D74367



More information about the llvm-commits mailing list