[PATCH] D95916: DebugInfo/Symbolize: Allow STT_NOTYPE/STT_GNU_IFUNC symbols for .symtab symbolization

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp:192
+  // optimization. Treat everything else (e.g. ELF STT_NOTYPE, STT_FUNC and
+  // STT_GNU_IFUNC) function symbols which can be symbolize addresses.
+  if (SymbolType == SymbolRef::ST_Data)
----------------
Looks like some of my previous comment wasn't addressed.


================
Comment at: llvm/test/DebugInfo/Symbolize/ELF/symtab-file.yaml:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-symbolizer --obj=%t 0 1 2 | FileCheck %s
----------------
jhenderson wrote:
> Top-level test comment saying what this test is trying to show? Same in the other tests.
Ping this in this particular file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95916/new/

https://reviews.llvm.org/D95916