[PATCH] D74393: [llvm-readobj] Add support for decoding FreeBSD ELF notes

Fri Feb 5 01:06:02 PST 2021

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, once the other related patches land. The `<?>` oddity can be sorted separately (unless a warning makes it obvious we're doing something silly in the YAML). I'm happy to investigate it myself, if you could provide the stderr (if any)?

================
Comment at: llvm/test/tools/llvm-readobj/ELF/note-freebsd-core.test:73
+# LLVM-NEXT:   NoteSection {
+# LLVM-NEXT:     Name: <?>
+# LLVM-NEXT:     Offset: 0xB0
----------------
arichardson wrote:
> jhenderson wrote:
> > Why the `<?>` for the name? Sounds like something odd is going on if I follow it correctly (there are perfectly good section headers as far as I can see from yaml). If it's expected, add a comment explaining why.
> I don't understand why this is happening, but it also appears to affect other tests. Possibly a bug in yaml2obj? Unfortunately I don't have time to investigate this.
Is there anything on stderr? I'd expect a warning in this case. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74393/new/

https://reviews.llvm.org/D74393