[PATCH] D77811: [clangd] Implement semanticTokens modifiers

Nathan Ridge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 01:00:28 PST 2021


nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.

I think this patch is in pretty good shape, the outstanding comments are either minor or thoughts about future changes.

I am curious what you think of the extension idea for readonly <https://reviews.llvm.org/D77811?id=320218#inline-896431>, though obviously it wouldn't be something to do in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77811/new/

https://reviews.llvm.org/D77811



More information about the llvm-commits mailing list