[PATCH] D96098: [X86] Don't pass a 1 to the secon argument of ISD::FP_ROUND in LowerFCOPYSIGN.

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added a comment.

> I don't think we have any reason to believe the FP_ROUND here doesn't change the value.

But I think the change here doesn't matter since we clear all non sign bits later.



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:21903
   if (Sign.getSimpleValueType().bitsGT(VT))
-    Sign = DAG.getNode(ISD::FP_ROUND, dl, VT, Sign, DAG.getIntPtrConstant(1, dl));
+    Sign = DAG.getNode(ISD::FP_ROUND, dl, VT, Sign,
+                       DAG.getIntPtrConstant(0, dl));
----------------
Better change the format as Lint suggested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96098/new/

https://reviews.llvm.org/D96098