[PATCH] D93762: SCCP: Refactor SCCPSolver

[Vinay Madhusudan via Phabricator via llvm-commits]

mivnay marked an inline comment as done.
mivnay added inline comments.


================
Comment at: include/llvm/Transforms/Scalar/SCCP.h:30
 #include "llvm/Transforms/Utils/PredicateInfo.h"
+#include "llvm/Transforms/Utils/SCCPSolver.h"
 
----------------
sanwou01 wrote:
> Ideally, this include should not be needed.
> 
> Perhaps keep the definition of `struct AnalysisResultsForFn` in this file (as it is part of the `runIPSCCP` interface) and create a similar (but differently named) struct for the implementation detail of the `SCCPSolver`.
`struct AnalysisResultsForFn` is part of the `SCCPSolver.AnalysisResults`. `runIPSCCP` just passes it on to the `SCCPSolver` via ` void SCCPSolver::addAnalysis(Function &F, AnalysisResultsForFn A)` interface. It would be compilation error to pass a different type. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93762/new/

https://reviews.llvm.org/D93762