[PATCH] D95967: [DAGCombiner][SVE] Fix invalid use of getVectorNumElements() in visitSRA.

[Huihui Zhang via Phabricator via llvm-commits]

huihuiz updated this revision to Diff 321629.
huihuiz marked an inline comment as done.
huihuiz added a comment.

Thanks David and Paul for the reviews!

I have included test coverage for the second change of getVectorElementCount.

But when trying to use changeVectorElementType(), I ran into a case where VT is v3i16, and the computed ExtVT is v3i1 not a valid simple integer vector type. We might end up needing extra special handling for i1 and other types.
Please refer to detailed test case in the comments.

Let me know if it's ok to keep the usage of EVT::getVectorVT(..., ElementCount) ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95967/new/

https://reviews.llvm.org/D95967

Files:
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/test/CodeGen/AArch64/DAGCombine_vscale.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95967.321629.patch
Type: text/x-patch
Size: 5166 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210205/f8858d33/attachment.bin>