[PATCH] D96079: Move implementation of isAssumeLikeIntrinsic into IntrinsicInst

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicInst.h:104
+    }
+    return false;
+  }
----------------
dexonsmith wrote:
> Usually we'd have a `default: break;` or `default: return false;` if the switch isn't totally covered... is there a reason you removed it when moving the code?
Will add, thanks!


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:526
-      default: break;
-      // FIXME: This list is repeated from NoTTI::getIntrinsicCost.
-      case Intrinsic::assume:
----------------
dexonsmith wrote:
> Should this FIXME be kept?
I have checked, it is not relevant anymore. The list there is way longer now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96079/new/

https://reviews.llvm.org/D96079