[PATCH] D95929: [CSSPGO][llvm-profgen] Add brackets for context id to support extended binary format

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.

In D95929#2542885 <https://reviews.llvm.org/D95929#2542885>, @wlei wrote:

> use a final clean up pass for the bracket adding

Thanks! Looks a lot cleaner now.



================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:421
   // Enable CS and pseudo probe functionalities in SampleProf
   FunctionSamples::ProfileIsCS = true;
   FunctionSamples::ProfileIsProbeBased = true;
----------------
This should not be needed either. Perhaps in the future we'll also have the profile writer automatically detect pseudo-probe-based profiles and set `FunctionSamples::ProfileIsProbeBased`. 


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.h:70
     // Enable context-sensitive functionalities in SampleProf
     FunctionSamples::ProfileIsCS = true;
     for (const auto &BI : BinarySampleCounters) {
----------------
This should be removed since now every context has brackets.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95929/new/

https://reviews.llvm.org/D95929