[PATCH] D96028: [RISCV] Add patterns for scalable-vector fabs & fcopysign

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1628
+
+  // Return a custom node to prevent infinite DAGCombien loops
+  return DAG.getNode(RISCVISD::VFCOPYSIGN, DL, VT, Op.getOperand(0), In2);
----------------
DAGCombien->DAGCombine


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1629
+  // Return a custom node to prevent infinite DAGCombien loops
+  return DAG.getNode(RISCVISD::VFCOPYSIGN, DL, VT, Op.getOperand(0), In2);
+}
----------------
Should this use the VFSGNJX name?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96028/new/

https://reviews.llvm.org/D96028