[PATCH] D95994: [ELF] Allow R_386_GOTOFF from .debug_info

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Thanks for the review!

In D95994#2541271 <https://reviews.llvm.org/D95994#2541271>, @peter.smith wrote:

> Change LGTM. For a future change, would it be worth looking at this from another direction and saying what can we disallow in non SHF_ALLOC sections, for example PC-relative? There can be an allow-list for known relocations and perhaps a warning for unknown ones. This should make us a little more resilient to changes in objects.

I stumped upon `isStaticLinkTimeConstant` - the non PC-relative relocation types can potentially be used in DW_AT_GNU_call_site_value. If such a request raises in the next time, we should try refactoring the isStaticLinkTimeConstant list and make that accessible from InputSection.cpp.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95994/new/

https://reviews.llvm.org/D95994