[PATCH] D96030: NFC: Migrate CodeMetrics to work on InstructionCost
David Sherwood via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 4 08:49:39 PST 2021
david-arm added inline comments.
================
Comment at: llvm/lib/Analysis/CodeMetrics.cpp:183
+ NumInstsProxy += TTI.getUserCost(&I, TargetTransformInfo::TCK_CodeSize);
+ NumInsts = *NumInstsProxy.getValue();
}
----------------
david-arm wrote:
> Isn't this a rolling value that needs incrementing? It's an unsigned value in CodeMetrics.h.
Sorry ignore that comment. :) I missed the fact that it's picking up the incremented NumInstsProxy.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96030/new/
https://reviews.llvm.org/D96030
More information about the llvm-commits
mailing list