[PATCH] D95373: Replace vector intrinsics with call to vector library

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.

LGTM - see inline for a couple of minor points.



================
Comment at: llvm/lib/CodeGen/ReplaceWithVeclib.cpp:80
+  if (isa<FPMathOperator>(Replacement)) {
+    assert(OldFunc->getFunctionType() == TLIFunc->getFunctionType() &&
+           "Expecting function types to be identical");
----------------
Move this above the replaceAllUsesWith() to be more effective (not just for FP calls)?


================
Comment at: llvm/test/CodeGen/Generic/replace-intrinsics-with-veclib.ll:64
+
+define double @exp_f64(double %in) {
+; COMMON-LABEL: define {{[^@]+}}@exp_f64
----------------
The test comments that were here in the previous revision were helpful. I'd put those back (but put them outside of the function body to avoid interfering with the script's CHECK lines).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95373/new/

https://reviews.llvm.org/D95373