[PATCH] D70426: [DAGCombiner][RISCV] Avoid FCOPYSIGN folding of legalizing operand casts

Thu Feb 4 07:33:58 PST 2021

luismarques abandoned this revision.
luismarques added a comment.
Herald added a subscriber: vkmr.

In D70426#2522193 <https://reviews.llvm.org/D70426#2522193>, @david-arm wrote:

> LGTM. The changes to DAGCombiner seem reasonable to me and I can see an improvement in the X86 code too.

This patch was originally intended to address FCOPYSIGN issues that no longer exist (in such a significant). It also would need some tweaks when rebasing to avoid codegen regressions on new test cases, ones that arguably wouldn't be very clean. Furthermore, I believe @efriedma had argued that these legalization issues shouldn't be handled in the combiner. So, I've extracted the beneficial changes into a separate patch, D96037 <https://reviews.llvm.org/D96037>, and added you as a reviewer. I'm abandoning this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70426/new/

https://reviews.llvm.org/D70426