[PATCH] D91737: [Dexter] Avoid potentially infinite loop in dbgeng driver

[Jeremy Morse via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGc8e6cde95c8c: [Dexter] Avoid infinite loop in dbgeng driver (authored by jmorse).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91737/new/

https://reviews.llvm.org/D91737

Files:
  debuginfo-tests/dexter/dex/debugger/dbgeng/dbgeng.py


Index: debuginfo-tests/dexter/dex/debugger/dbgeng/dbgeng.py
===================================================================
--- debuginfo-tests/dexter/dex/debugger/dbgeng/dbgeng.py
+++ debuginfo-tests/dexter/dex/debugger/dbgeng/dbgeng.py
@@ -103,8 +103,11 @@
         self.step_info = res
 
     def go(self):
-        # We never go -- we always single step.
-        pass
+        # FIXME: running freely doesn't seem to reliably stop when back in a
+        # relevant source file -- this is likely to be a problem when setting
+        # breakpoints. Until that's fixed, single step instead of running
+        # freely. This isn't very efficient, but at least makes progress.
+        self.step()
 
     def _get_step_info(self, watches, step_index):
         frames = self.step_info


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91737.321417.patch
Type: text/x-patch
Size: 792 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210204/0b375643/attachment.bin>