[PATCH] D95464: [flang][driver] Add PrescanAction frontend action (nfc)

Faris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 4 05:02:13 PST 2021


FarisRehman accepted this revision.
FarisRehman added a comment.
This revision is now accepted and ready to land.

Thanks for working on this @awarzynski, this patch allows actions that do not need to run the prescanner to not do so.
I've left a nit, but otherwise LRTM!



================
Comment at: flang/lib/Frontend/FrontendActions.cpp:29
+  // extension. Ideally we should have all Fortran options set before
+  // entering this loop (i.e. processing any input files). However, we
+  // can't decide between fixed and free form based on the file extension
----------------
[nit] Update this comment to reflect the move of this line from the loop into this method, e.g. removing mention of the loop like `Ideally we should have all Fortran options set before processing any input files.`?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95464/new/

https://reviews.llvm.org/D95464



More information about the llvm-commits mailing list