[llvm] fa2cdb8 - [X86] Remove stale TODO comment. NFC.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 4 04:14:22 PST 2021


Author: Simon Pilgrim
Date: 2021-02-04T12:14:05Z
New Revision: fa2cdb81407b9859794e4a47fc65d20a110e338c

URL: https://github.com/llvm/llvm-project/commit/fa2cdb81407b9859794e4a47fc65d20a110e338c
DIFF: https://github.com/llvm/llvm-project/commit/fa2cdb81407b9859794e4a47fc65d20a110e338c.diff

LOG: [X86] Remove stale TODO comment. NFC.

We now handle implicit zero-extension shuffle mask cases.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index ae5edce2cbdc..538f5c68906b 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -40371,8 +40371,6 @@ static SDValue combineExtractWithShuffle(SDNode *N, SelectionDAG &DAG,
       while (Mask.size() > NumSrcElts &&
              canWidenShuffleElements(Mask, WidenedMask))
         Mask = std::move(WidenedMask);
-      // TODO - investigate support for wider shuffle masks with known upper
-      // undef/zero elements for implicit zero-extension.
     }
   }
 


        


More information about the llvm-commits mailing list