[PATCH] D96001: [WebAssembly][lld] Precolor table numbers for MVP inputs
    Andy Wingo via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Feb  4 01:51:42 PST 2021
    
    
  
wingo added a comment.
Looking over this changeset, I see that we need some tests.  But also there is a fair amount of code duplication for the "precoloring" logic.  I can make it be a part of TableSymbol::setTableNumber and InputTable::setTableNumber; it would seem that that much duplication is necessary.  But then the errors would probably be less helpful because there's less context at that point.  Thoughts?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96001/new/
https://reviews.llvm.org/D96001
    
    
More information about the llvm-commits
mailing list