[PATCH] D95953: yaml2obj: Handle NT_* string values in for ELF note types

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 4 01:37:01 PST 2021


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one optional suggestion.



================
Comment at: llvm/test/tools/yaml2obj/ELF/note-section.yaml:310
+# RUN: yaml2obj --docnum=15 %s -o %t15
+# RUN: llvm-readobj --sections --section-data %t15 | FileCheck %s --check-prefix=TEXTUAL-TYPE
+
----------------
Alternatively, `-x .note.foo` would be enough. Not sure which is simpler.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95953/new/

https://reviews.llvm.org/D95953



More information about the llvm-commits mailing list