[PATCH] D95843: [tools][llvm-libtool] Emit warnings for files without symbols

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

`no_warning_for_no_symbols` probably needs adding to the Comand Guide?



================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:94
+    "no_warning_for_no_symbols",
+    cl::desc("Do not warn about files that have no symbols."),
+    cl::cat(LibtoolCategory), cl::init(false));
----------------
Nit: other descriptions don't appear to end with a full stop.


================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:260
+  if (!NoWarningForNoSymbols && O->symbols().empty())
+    WithColor::warning() << Member.MemberName + " has no symbols.\n";
+
----------------
Nit: don't end diagnostic messages with trailing full stop (as per style guide).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95843/new/

https://reviews.llvm.org/D95843