[PATCH] D95932: [Debug-Info] [NFC] move emitDwarfUnitLength to MCStreamer class

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added inline comments.


================
Comment at: llvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp:297-313
 class AsmPrinterMaybeEmitDwarf64MarkTest : public AsmPrinterFixtureBase {};
 
 TEST_F(AsmPrinterMaybeEmitDwarf64MarkTest, DWARF32) {
   if (!init("x86_64-pc-linux", /*DwarfVersion=*/4, dwarf::DWARF32))
     return;
 
   EXPECT_CALL(TestPrinter->getMS(), emitIntValue(_, _)).Times(0);
----------------
This test file is for methods of `AsmPrinter`; other classes should be tested elsewhere. As the patch removes `AsmPrinter::maybeEmitDwarf64Mark()`, the corresponding tests can also be removed. That will not degrade the test coverage because `MCStreamer::maybeEmitDwarf64Mark()` is tested, although indirectly, in other tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95932/new/

https://reviews.llvm.org/D95932