[PATCH] D88391: [M68k] (Patch 5/8) Target lowering

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kISelLowering.cpp:1453
+  // MUL on values larger than 16 bits cannot be handle by M68000 and M68010
+  if (!Subtarget.atLeastM68020()) {
+    EVT VT = N->getValueType(0);
----------------
RKSimon wrote:
> Why not set Legal/Custom in setOperationAction ISD::MUL based on Subtarget?
yes you're right, this entire function can be replaced by setOperation(LibCall) for i32 and i64 on older sub-architectures.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88391/new/

https://reviews.llvm.org/D88391