[PATCH] D95633: [test-suite] SPEC2017 CPU CactuBSSN floating point tests.
Michael Kruse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 3 19:07:08 PST 2021
Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: External/SPEC/CFP2017rate/507.cactuBSSN_r/CMakeLists.txt:50-52
+target_compile_definitions(${PROG} PRIVATE $<$<COMPILE_LANGUAGE:Fortran>:FCODE>)
+target_compile_definitions(${PROG} PRIVATE $<$<COMPILE_LANGUAGE:C>:CCODE>)
+target_compile_definitions(${PROG} PRIVATE $<$<COMPILE_LANGUAGE:CXX>:CCODE CCTK_DISABLE_RESTRICT=1>)
----------------
test-suite style usually defines compilation/linking options before adding the target (e.g. by setting LDFALGS, CFLAGS, CXXCLAGS), `add_compile_definitions` would be more consistent than `target_compile_definitions`.
But I also don't think its important.
Repository:
rT test-suite
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95633/new/
https://reviews.llvm.org/D95633
More information about the llvm-commits
mailing list