[PATCH] D78796: [Support] Refactor LEB128 encoding into an input iterator

Nicolas Guillemot via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 3 17:19:15 PST 2021


nlguillemot updated this revision to Diff 321269.
nlguillemot edited the summary of this revision.
nlguillemot added a comment.
Herald added a subscriber: dexonsmith.

- Address various review feedback (see relevant comment threads).
- Made `IsSigned` a template parameter.
- Moved the core logic of LEB128 encoding into its own function to better separate it from the syntactical sugar.
- Added some convenience functions for creating LEB128 input iterator ranges.
- Used these new input iterator ranges to simplify some code in FixedLenDecoderEmitter.cpp.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78796/new/

https://reviews.llvm.org/D78796

Files:
  llvm/include/llvm/Support/LEB128.h
  llvm/utils/TableGen/FixedLenDecoderEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78796.321269.patch
Type: text/x-patch
Size: 16584 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210204/e9ef13e1/attachment.bin>


More information about the llvm-commits mailing list