[PATCH] D95843: [tools][llvm-libtool] Emit warnings for files without symbols

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 3 17:10:04 PST 2021


smeenai added a comment.

In D95843#2540709 <https://reviews.llvm.org/D95843#2540709>, @alexshap wrote:

> @smeenai : many thanks for the review,
>
> 1. regarding bitcode files: cctools libtool doesn't warn on them
> 2. regarding input files which are filtered out by -arch_only: cctools libtool doesn't warn on them either
>
> Perhaps, it makes sense to add tests for these cases

Yup, we should definitely add tests.

We're currently checking for no symbols before we do the `-arch_only` filtering, right? So our current behavior diverges from cctools?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95843/new/

https://reviews.llvm.org/D95843



More information about the llvm-commits mailing list