[PATCH] D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:277-278
+    orderedCollapseLevel = orderedLevel;
+  }
+  if (collapseLevel > orderedLevel) {
+    orderedCollapseLevel = collapseLevel;
----------------
An else to the previous if is better.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:1039
   }
+  ClearThreadPrivateSymbols();
   PopContext();
----------------
Will this work if there are two omp do loops having threadprivate iteration variables?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92732/new/

https://reviews.llvm.org/D92732