[PATCH] D95929: [CSSPGO][llvm-profgen] Add brackets for context id to support extended binary format

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:276
+    } else {
+      OCalleeCtxStr << "[";
     }
----------------
wlei wrote:
> hoy wrote:
> > Should this be run unconditionally?
> in line273 `ContextId.rsplit(" @ ").first.str();` has already had the '[', so only add for the else branch
I see. I'm wondering if it's possible to find a place that can centralize the appending of brackets, say right before populating or looking up the function profiles?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95929/new/

https://reviews.llvm.org/D95929