[PATCH] D88715: [llvm-objdump] --source: drop the warning when there is no debug info

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1018
   DILineInfo LineInfo = DILineInfo();
   auto ExpectedLineInfo = Symbolizer->symbolizeCode(*Obj, Address);
   std::string ErrorMessage;
----------------
`auto` -> `Expected<DILineInfo>` to be more readable


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1029
-  if (LineInfo.FileName == DILineInfo::BadString) {
-    if (!WarnedNoDebugInfo) {
-      std::string Warning =
----------------
Does removing the `WarnedNoDebugInfo` check mean that if debug info is present & malformed, we'll start displaying one message per line that the debug info is malformed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88715/new/

https://reviews.llvm.org/D88715