[PATCH] D95914: [lld][WebAssembly] Fix for weak undefined functions in -pie mode

[Derek Schuff via Phabricator via llvm-commits]

dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/test/wasm/weak-undefined-pic.s:72
 
-# With `-pie` or `-shared` the resolution should be deferred to the dynamic
-# linker and the function address should be imported as GOT.func.foo.
+# With `-pie + + --unresolved-symbols=import-functions` or `-shared` the
+# resolution should be deferred to the dynamic linker and the function address
----------------



================
Comment at: lld/test/wasm/weak-undefined-pic.s:97
+
+# With just `-pie` (which does not default to import-functions) there shoule be
+# no import at all.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95914/new/

https://reviews.llvm.org/D95914