[PATCH] D95373: Replace vector intrinsics with call to vector library

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/lib/CodeGen/ReplaceWithVeclib.cpp:79
+  CI.replaceAllUsesWith(Replacement);
+  if (isa<FPMathOperator>(Replacement)) {
+    // Preserve fast math flags for FP math.
----------------
Can we assert here that the FunctionType of `Replacement` is the same as the FunctionType of `CI`?


================
Comment at: llvm/lib/CodeGen/ReplaceWithVeclib.cpp:165
+    // Found the correct mapping in the TargetLibraryInfo,
+    // replace the call to the instrinsic with a call to
+    // the vector library function.
----------------
typo: intrinsic


================
Comment at: llvm/lib/CodeGen/ReplaceWithVeclib.cpp:186
+  }
+  // Erase the calls to the intrincis that have been replaced
+  // with calls to the vector library.
----------------
typo: intrinsics


================
Comment at: llvm/test/CodeGen/Generic/replace-intrinsics-with-veclib.ll:14
+; LIBMVEC-X86-SAME: i8* bitcast (<4 x double> (<4 x double>)* @_ZGVdN4v_exp to i8*),
+; LIBMVEC-X86-sAME: i8* bitcast (<4 x float> (<4 x float>)* @_ZGVbN4v_expf to i8*)
+; F32-SAME: [1 x i8*] [
----------------
FileCheck typo: "sAME"

Can you use utils/update_test_checks.py to auto-generate the assertions?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95373/new/

https://reviews.llvm.org/D95373