[PATCH] D95080: [flang] Fix creation of deferred shape arrays by POINTER statement

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld added a comment.

In D95080#2523025 <https://reviews.llvm.org/D95080#2523025>, @MaskRay wrote:

> In your commit the message does not include `Reviewed by:`. Many people agree that both `Reviewed by:` & `Differential Revision:` should be present. The `Reviewed by:` list indicates people who acknowledged the patch. (The `Reviewers:` list does not necessarily mean all the people on the list have acknowledged the patch so `Reviewers:` is mostly useless.)
>
> `arc amend` can fetch the Phabricator summary and amend the local description.
>
> You can install `llvm/utils/git/pre-push.py` to prevent accidental `Summary:`, `Reviewers:`, `Subscribers:` and `Tags:` in the presence of `Differential Revision:`.

Thanks for watching over these revisions.  From what I can tell, the "arc diff" command adds a line to the commit message that contains a link to the Differential Revision.  Here's an excerpt from the commit message from a more recent update of mine that "arc diff" added:

  Differential Revision: https://reviews.llvm.org/D95894

The Differential Revision, in turn, contains information about who reviewed and approved the change.  So it seems to me that adding that information to the commit message is redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95080/new/

https://reviews.llvm.org/D95080