[PATCH] D93394: CodeGen: Move function to get subregister indexes to cover a LaneMask

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetRegisterInfo.h:366
+                                    LaneBitmask LaneMask,
+                                    SmallVectorImpl<unsigned> &Indexes) const;
+
----------------
The API looks fine but I think the comment could be clearer.

E.g., what is the best matching index when we need more than one indexes?

Maybe we could return a bool: a covering exists or not, and just always fill `Indexes`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93394/new/

https://reviews.llvm.org/D93394