[PATCH] D95929: [CSSPGO][llvm-profgen] Add brackets for context id to support extended binary format
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 3 11:01:23 PST 2021
hoy added inline comments.
================
Comment at: llvm/lib/ProfileData/SampleProfWriter.cpp:364
if (FunctionSamples::ProfileIsCS)
- OS << "[" << S.getNameWithContext() << "]:" << S.getTotalSamples();
+ OS << S.getNameWithContext(true) << ":" << S.getTotalSamples();
else
----------------
The whole `if-else` can be just replaced by `OS << S.getNameWithContext(true) << ":" << S.getTotalSamples();`
================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:276
+ } else {
+ OCalleeCtxStr << "[";
}
----------------
Should this be run unconditionally?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95929/new/
https://reviews.llvm.org/D95929
More information about the llvm-commits
mailing list