[PATCH] D95432: AMDGPU/GlobalISel: Combine uniform icmp

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegBankCombiner.cpp:123-126
+  if (MatchInfo.TruncDef) {
+    MRI.getVRegDef(MatchInfo.TruncDef)->eraseFromParent();
+    B.buildTrunc(MatchInfo.TruncDef, MatchInfo.ICmpDef);
+  }
----------------
I don't think this should be trying to find defs and move them. If we're CSEing, just creating the instruction you need would get the desired result


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95432/new/

https://reviews.llvm.org/D95432