[PATCH] D95245: [SVE] Add support for scalable vectorization of loops with int/fast FP reductions

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 3 08:39:46 PST 2021


david-arm added a comment.

LGTM! Thanks for making all changes. Perhaps wait a while before merging in case others want a look?



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1522
+  bool canVectorizeReductions(ElementCount VF) {
+    return (llvm::all_of(Legal->getReductionVars(), [&](auto &Reduction) -> bool {
+      RecurrenceDescriptor RdxDesc = Reduction.second;
----------------
nit: I think you can remove the '(' and ')' surrounding the llvm::all_of call here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95245/new/

https://reviews.llvm.org/D95245



More information about the llvm-commits mailing list