[PATCH] D95950: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 3 08:21:40 PST 2021


SouraVX added a comment.

In D95950#2539385 <https://reviews.llvm.org/D95950#2539385>, @schweitz wrote:

> In D95950#2539183 <https://reviews.llvm.org/D95950#2539183>, @SouraVX wrote:
>
>> Built and tested locally.
>
> I think the fir-ops.fir test might need to be updated.
>
> Thanks for the renaming merge!

I noticed following snippet in `fir-ops.fir`, Suggesting some changes are already there ?

  // CHECK-LABEL: func @loop() {
  func @loop() {
  ...
  
  // CHECK: fir.do_loop [[VAL_65:%.*]] = [[VAL_62]] to [[VAL_63]] step [[VAL_62]] {
  ...
      }
    }
    fir.unreachable
  }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95950/new/

https://reviews.llvm.org/D95950



More information about the llvm-commits mailing list