[PATCH] D95917: [ELF] Improve --icf=safe diagnostic

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Seems reasonable to me. I gues my only question is: will most users understand what the address-significance table is?



================
Comment at: lld/ELF/InputFiles.cpp:596
+          warn(toString(this) + ": --icf=safe conservatively ignores "
+                                ".llvm_addrsig with sh_link=0 "
+                                "(likely created using objcopy or ld -r)");
----------------
This should probably use the action section name, rather than hard-coding it in, since there's no requirement that SHT_LLVM_ADDRSIG sections be a specific name, to my knowledge. The section index might also be good. See also the `describe` method used by llvm-readobj for how we report issues with sections there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95917/new/

https://reviews.llvm.org/D95917