[PATCH] D95591: [yaml2obj/obj2yaml] - Implement program header table as a special Chunk.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 23:52:21 PST 2021


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Thanks for the explanation. `Type: ProgramHeaderTable` looks good. `Layout:` instead of `Sections:` can indeed make things less confusing but that would be a large refactoring on its own. I think making them aliases may not be straightforward to implement to ObjectYAML... The few `check-lldb-shell` tests still need to be fixed first.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95591/new/

https://reviews.llvm.org/D95591



More information about the llvm-commits mailing list