[llvm] 511c9a7 - [AsmPrinter] Use ListSeparator (NFC)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 2 22:53:14 PST 2021
Author: Kazu Hirata
Date: 2021-02-02T22:52:48-08:00
New Revision: 511c9a76fb98efda5019b4e6d07bea395ce1df78
URL: https://github.com/llvm/llvm-project/commit/511c9a76fb98efda5019b4e6d07bea395ce1df78
DIFF: https://github.com/llvm/llvm-project/commit/511c9a76fb98efda5019b4e6d07bea395ce1df78.diff
LOG: [AsmPrinter] Use ListSeparator (NFC)
Added:
Modified:
llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
Removed:
################################################################################
diff --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
index 85754bf29d0c..b6f100984492 100644
--- a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
@@ -922,13 +922,9 @@ static bool emitDebugValueComment(const MachineInstr *MI, AsmPrinter &AP) {
const DIExpression *Expr = MI->getDebugExpression();
if (Expr->getNumElements()) {
OS << '[';
- bool NeedSep = false;
+ ListSeparator LS;
for (auto Op : Expr->expr_ops()) {
- if (NeedSep)
- OS << ", ";
- else
- NeedSep = true;
- OS << dwarf::OperationEncodingString(Op.getOp());
+ OS << LS << dwarf::OperationEncodingString(Op.getOp());
for (unsigned I = 0; I < Op.getNumArgs(); ++I)
OS << ' ' << Op.getArg(I);
}
diff --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
index 4a67b0bc2c4d..b3327aff082a 100644
--- a/llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
@@ -577,10 +577,10 @@ void AsmPrinter::emitInlineAsm(const MachineInstr *MI) const {
SrcMgr.getMemoryBuffer(BufNum)->getBuffer().begin());
std::string Msg = "inline asm clobber list contains reserved registers: ";
- for (auto I = RestrRegs.begin(), E = RestrRegs.end(); I != E; ++I) {
- if(I != RestrRegs.begin())
- Msg += ", ";
- Msg += TRI->getName(*I);
+ ListSeparator LS;
+ for (const Register &RR : RestrRegs) {
+ Msg += LS;
+ Msg += TRI->getName(RR);
}
const char *Note =
"Reserved registers on the clobber list may not be "
More information about the llvm-commits
mailing list