[PATCH] D95926: [X86] Correct types in tablegen multiclasses found by D95874.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrAVX512.td:3314
 
-defm KSET0 : avx512_mask_setop_w<immAllZerosV>;
-defm KSET1 : avx512_mask_setop_w<immAllOnesV>;
+defm KSET0 : avx512_mask_setop_w<(immAllZerosV)>;
+defm KSET1 : avx512_mask_setop_w<(immAllOnesV)>;
----------------
Should we make immAllZerosV and immAllOnesV inherit from SDPatternOperator?


================
Comment at: llvm/lib/Target/X86/X86InstrAVX512.td:5303
 multiclass avx512_fp_scalar<bits<8> opc, string OpcodeStr,X86VectorVTInfo _,
-                            SDNode OpNode, SDNode VecNode,
+                            PatFrags OpNode, SDNode VecNode,
                             X86FoldableSchedWrite sched, bit IsCommutable> {
----------------
Maybe we should jus use SDPatternOperator instead of PatFrags in these?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95926/new/

https://reviews.llvm.org/D95926